DescriptionSizing adjustments in sign-in and welcome to chrome pages.Match button height in signin page and welcome page.Change spacing to 32pt on compact and regular layouts.Before & after screenshots here: https://drive.google.com/open?id=0BxrfNSu8yqJqUFJZMjR6ZWNxeWcBUG=670600Review-Url: https://codereview.chromium.org/2596293002Cr-Commit-Position: refs/heads/master@{#442552}Committed: https://chromium.googlesource.com/chromium/src/+/4fc797dfb92b3e0e3b550ca922afd79df89b7f37 Patch Set 1 # Patch Set 2 : aligning sign-in icons # Patch Set 3 : correct sizing # Download [raw][tar.bz2] Unified diffs | Side-by-side diffs | Delta from patch set | Stats (+14 lines, -9 lines) | Patch |
---|
M | ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm | View | 2 chunks | +4 lines, -4 lines | 0 comments | Download | M | ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm | View | 2 chunks | +7 lines, -2 lines | 0 comments | Download | M | ios/chrome/browser/ui/settings/cells/account_control_item.mm | View | 2 chunks | +3 lines, -3 lines | 0 comments | Download |
Messages Total messages: 21 (9 generated) Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages lody | lod@chromium.org changed reviewers: + bzanotti@chromium.org |
| 4 years, 2 months ago (2016-12-23 08:56:02 UTC) #1 |
lody | changes are per jasonkliu,please review. Button height modification was already reviewed prior to open-sourcing by .. |
| 4 years, 2 months ago (2016-12-23 08:56:03 UTC) #2 |
lody | + lpromero to review account_control_item.mm , thanks |
| 4 years, 2 months ago (2016-12-28 09:24:56 UTC) #3 |
lody | lod@chromium.org changed reviewers: + lpromero@chromium.org |
| 4 years, 2 months ago (2016-12-28 09:43:02 UTC) #4 |
lody | | 4 years, 2 months ago (2016-12-28 09:43:02 UTC) #5 |
bzanotti | The code looks good to me, but could you add some before/after screenshots? |
| 4 years, 2 months ago (2017-01-02 12:22:10 UTC) #6 |
lody | Description was changed from Sizing adjustements in sign-in and welcome to chrome pages. Match .. |
| 4 years, 2 months ago (2017-01-02 15:40:16 UTC) #7 |
lody | Description was changed from Sizing adjustements in sign-in and welcome to chrome pages. Match .. |
| 4 years, 2 months ago (2017-01-02 15:40:28 UTC) #8 |
lody | Added screenshots in description. |
| 4 years, 2 months ago (2017-01-02 15:40:45 UTC) #9 |
bzanotti | On 2017/01/02 15:40:45, lody wrote: > Added screenshots in description. The screenshots don't cover the .. |
| 4 years, 2 months ago (2017-01-02 16:02:07 UTC) #10 |
lody | On 2017/01/02 16:02:07, bzanotti wrote: > On 2017/01/02 15:40:45, lody wrote: > > Added screenshots .. |
| 4 years, 2 months ago (2017-01-02 16:12:38 UTC) #11 |
bzanotti | On 2017/01/02 16:12:38, lody wrote: > On 2017/01/02 16:02:07, bzanotti wrote: > > On 2017/01/02 .. |
| 4 years, 2 months ago (2017-01-02 16:21:58 UTC) #12 |
lpromero | | 4 years, 2 months ago (2017-01-05 11:06:30 UTC) #13 |
lody | Description was changed from Sizing adjustments in sign-in and welcome to chrome pages. Match .. |
| 4 years, 1 month ago (2017-01-09 10:17:46 UTC) #14 |
lody | On 2017/01/02 16:21:58, bzanotti wrote: > On 2017/01/02 16:12:38, lody wrote: > > On 2017/01/02 .. |
| 4 years, 1 month ago (2017-01-09 12:27:09 UTC) #15 |
lody | The CQ bit was checked by lod@chromium.org |
| 4 years, 1 month ago (2017-01-10 10:39:52 UTC) #16 |
lody | The patchset sent to the CQ was uploaded after l-g-t-m from bzanotti@chromium.org, lpromero@chromium.org Link to .. |
| 4 years, 1 month ago (2017-01-10 10:39:53 UTC) #17 |
commit-bot: I haz the power | CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596293002/40001 |
| 4 years, 1 month ago (2017-01-10 10:40:06 UTC) #18 |
commit-bot: I haz the power | CQ is committing da patch. Bot data: {'patchset_id': 40001, 'attempt_start_ts': 1484044792739050, 'parent_rev': 'c9d730859cc5a2c4eb8226040f565d1df141b142', 'commit_rev': '4fc797dfb92b3e0e3b550ca922afd79df89b7f37'} |
| 4 years, 1 month ago (2017-01-10 10:49:07 UTC) #19 |
commit-bot: I haz the power | Description was changed from Sizing adjustments in sign-in and welcome to chrome pages. Match .. |
| 4 years, 1 month ago (2017-01-10 10:49:41 UTC) #20 |
commit-bot: I haz the power | Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4fc797dfb92b3e0e3b550ca922afd79df89b7f37 |
| 4 years, 1 month ago (2017-01-10 10:49:42 UTC) #21 |
Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages |